Refactor: Remove sampler dependency on MapData (github issue #168) #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following changes to remove the Sampler class dependency on MapData class:
get_value_from_raster_df
and__value_from_raster
from MapData to utils.py and renamed them toset_z_values_from_raster_df
andvalue_from_raster
extract_geology_contacts
in project.pycalculate_fault_orientations
in project.pysummarise_fault_data
in project.pysample
in SamplerDecimator classcompute
in InterpolatedStructure classValidation
I ran the code in map2loop-notebooks/Example 3- Local Source Data.ipynb and compared the returned result from
set_z_values_from_raster_df
function insideextract_geology_contacts
. The results from the current master branch and the refactored code are the same.