Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ng2-pdfjs-viewer package #108

Open
dskaggs opened this issue Feb 2, 2021 · 0 comments
Open

Replace ng2-pdfjs-viewer package #108

dskaggs opened this issue Feb 2, 2021 · 0 comments
Labels
area/ui dependencies Pull requests that update a dependency file size/medium type/maintenance General repo maintenance that doesn't fit into other labels

Comments

@dskaggs
Copy link
Contributor

dskaggs commented Feb 2, 2021 •
edited

ng2-pdfjs-viewer hasn't been updated in over a year and only supports Angular through v8. In order to update to Angular 11 and beyond, we need to find a new embeddable PDF viewer package to use in the app.

Possible replacement: ngx-extended-pdf-viewer

Edit: I was able to "force" update Angular to v11.x but ng2-pdfjs-viewer still causes problems every time you need to upgrade Angular b/c of it's old dependency settings.
@dskaggs dskaggs added dependencies Pull requests that update a dependency file type/maintenance General repo maintenance that doesn't fit into other labels size/medium area/ui labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui dependencies Pull requests that update a dependency file size/medium type/maintenance General repo maintenance that doesn't fit into other labels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dskaggs