Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code update #54

Closed
ResTedRU opened this issue Jan 10, 2022 · 2 comments
Closed

General code update #54

ResTedRU opened this issue Jan 10, 2022 · 2 comments

Comments

@ResTedRU
Copy link

I have been trying to build a project lately, but I keep running into problems that are related to outdated tools and libraries. Is it possible to make a global update for code and tools in order to use current tools, for example VS2022. (talking about the assembly on Windows)

Also, after the last update job_logger, new data have been added that can be obtained from game, and some old data have been changed.
For example:

  1. update was added: when you use F7 when using an external contract, then the cargo in the game disappears, but the program does not see it (there must be an event - refusal of cargo: change of status from 1 = OnJob to 2 = Cancelled )

  2. some data we receive does not contain valid data, but for some reason such data is replaced by _0.
    This is probably due to the fact that . is replaced by _ . (https://prnt.sc/26c6n2i)

I hope this will be possible.
I would like to support you in this in different ways ))

@Lihis
Copy link
Owner

Lihis commented Jan 11, 2022

About the libraries, one could check if the conanfile.txt has a way to "install always the latest version", that would be much better than manually bumping the versions. Otherwise the libraries should now be up-to-date (except forgot to bump up the cURL version) but the build is broken, see #53.

What comes to Visual Studio, I haven't had access to a Windows for a couple years. Someone was trying to use VS2019 but there was some build (see #9). So any PR's allowing to use newer VS is welcome (like for the #53).

when you use F7 when using an external contract, then the cargo in the game disappears, but the program does not see it

With F7 you mean the "tow to service"? The SDK only has cancelled and delivered so need to spin up and the game and add some logging to debug.

some data we receive does not contain valid data, but for some reason such data is replaced by _0

Seems weird. Some unit tests should be written at some point.

@Lihis
Copy link
Owner

Lihis commented Jan 23, 2022

Closing as code seems to be up-to-date because builds for three Linux distros (Arch Linux and Fedora added in 3722929) are passing. Also some first unit tests has been merged in #60 which seem to be passing.

@Lihis Lihis closed this as completed Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants