Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Inline lein-light-nrepl dependencies #44

Open
rundis opened this issue Apr 16, 2015 · 3 comments
Open

Inline lein-light-nrepl dependencies #44

rundis opened this issue Apr 16, 2015 · 3 comments

Comments

@rundis
Copy link
Contributor

rundis commented Apr 16, 2015

I would suggest we take the same route as:

I.e source-inlining dependencies using mranderson

That way I think we should be able to avoid many pesky dependency conflicts with clojure projects connecting through lein-light-nrepl.
I'd be willing to have a go at it once the atom-shell release is out.

@geoffrys
Copy link

geoffrys commented May 6, 2015

I've taken an initial stab at this, it's going quite slowly.

  1. Running source-deps is extremely slow: at first glance it seems that dependencies should be downloaded only if they don't already exist and then always re-mangle the project's files. You can avoid this to some degree by editing source in target/* and rerunning lein with-profile plugin.mranderson/config install
  2. lein-light-nrepl/src/lighttable/nrepl/core.clj org.apache.commons.io.output.WriterOutputStream. isn't caught by mranderson. Added to the ns macro.
  3. lein-light-nrepl/src/lighttable/nrepl/eval.clj (defn eval-clj [fs cur-ns & [opts]] the fs arg is assumed to be the dependency fs. Renamed to forms.
  4. clojure.data.json calls (load "json_compat_0_1") at the bottom of the file, json_compat_0_1.clj is not present after running source-deps
    ...

@rundis
Copy link
Contributor Author

rundis commented Jul 1, 2015

@geoffrys any further progress on this ?

@geoffrys
Copy link

geoffrys commented Jul 1, 2015

@rundis I'm afraid I ran out of time to look at it in May and haven't had time since.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants