Попытка раз. Требуется помощь. #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liberate520
reviewed
May 19, 2024
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class Family extends Human{ |
Owner
There was a problem hiding this comment.
Семья и человек это очевидно не одно и тоже. Наследование ошибочно. Например у Семьи нет пола или возраста, а у человека есть
Owner
There was a problem hiding this comment.
Возможно неудачно выбрано имя класса
Comment on lines
+9
to
+10
| private Human father, mother; | ||
| private List<Human> parents; |
Owner
There was a problem hiding this comment.
Не понял. Отдельно папа и мама и отдельно список родителей? Это не одно и тоже?
|
|
||
| public Human(String name, Gender gender, LocalDate birthDate) { | ||
| id = -1; | ||
| this.name = name.toString(); |
Owner
There was a problem hiding this comment.
зачем toString? name и так является стрингом
| import java.time.LocalDate; | ||
|
|
||
| public class Main { | ||
| public static void main(String[] args) { |
Owner
There was a problem hiding this comment.
Не показано создание родственных связей
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Предполагал сделать отдельно создание человек, отдельно создание семьи. А после образования семьи уже создание древа семьи, но что-то пошло не так.
Прошу помощи.