homework lesson1 #13
Open
homework lesson1 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liberate520
reviewed
Apr 12, 2024
Comment on lines
8
to
10
| public enum Gender { | ||
| MALE, FEMALE; | ||
| }; |
| private Calendar dob, dod; | ||
| private Human mother; | ||
| private Human father; | ||
| private final Gender gender; |
Owner
There was a problem hiding this comment.
Странно, что только это поле final ))
Liberate520
reviewed
May 15, 2024
| service.sortByAge(); | ||
| getFullList(); | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
Добавить методы сохранения и загрузки
| } | ||
|
|
||
| public void addHuman(String name, String surname, GregorianCalendar dob, Human.Gender gender, Integer mother, Integer father) { | ||
| Human hm = new Human(name, surname, dob, gender, fl.getHumanByIndex(mother), fl.getHumanByIndex(father)); |
Owner
There was a problem hiding this comment.
Лучше было бы сделать проверку. Вдруг id родителя не соответствует ни одной записи. Тогда надо сообщить о проблеме, прежде чем создавать новую запись
Comment on lines
22
to
24
| while (status) { | ||
| System.out.println("1. Add student"); | ||
| System.out.println("2. Get full family list"); |
Owner
There was a problem hiding this comment.
Нарушает второй принцип солид. При попытке добавления нового функционала придется переписывать метод
Liberate520
reviewed
May 16, 2024
|
|
||
| public class Service { | ||
| FamilyList<Human> fl; | ||
| private FileHandlerList fhl; |
Owner
There was a problem hiding this comment.
нарушает пятый принцип солид. Зависимость должна быть от абстракции
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.