Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XBM icon support #79

Open
rootcoma opened this issue Aug 9, 2014 · 16 comments
Open

XBM icon support #79

rootcoma opened this issue Aug 9, 2014 · 16 comments

Comments

@rootcoma
Copy link
Contributor

rootcoma commented Aug 9, 2014

Are you interested in supporting xbm icons?

The biggest problem I see is adding another 300 lines of code, and dependency for xcb_image.

I have created a branch with functioning xbm support, however I do not feel that it is ready for a PR. The code could use testing and some improvements to xbm support and string handling. If anyone has suggestions let me know.

rootcoma/bar@2043655

The syntax is

%{I<filename>} eg %{Iicons/clock.xbm}
@LemonBoy
Copy link
Owner

The reason that made me not implement this earlier (I had a big collection of xbm icons back then) was the shitload of code required to support those :<
However I see the code is well commented and ifdef shielded, I still have to think whether a dwm-like approach (having a list of patches for the user to apply) might work for bar too to keep the core lean)

@CamilleScholtz
Copy link

I made a patch that works with the latest git version if anyone's interested: https://github.com/6c37/crux-ports/blob/master/bar-xbm/xbm.patch

@wfdewith
Copy link

I would really like to try bar, but I am still stuck with dzen2 because of my xbm icons. Any updates @LemonBoy?

@LemonBoy
Copy link
Owner

If there's enough demand for such an option I'd be happy to include it, I had myself quite a huge stash of xbm icons but then switched to the artwiz font and never bothered to look back :)

@Bfgeshka
Copy link

It wound be great, because in this case people would be able to use much more fonts in bar instead of only iconic ones now.

@LemonBoy
Copy link
Owner

I've put together some nice (?) code that doesn't depend on xcb_image and works fine with the upcoming gradient-background support :D
Please ping me back if you don't get any news sometimes soon, I tend to forget about stuff :<

@CamilleScholtz
Copy link

ping~

Will this be merged into master any time soon?

@LemonBoy
Copy link
Owner

yep, but #105 is a blocker

@darvelo
Copy link

darvelo commented Mar 8, 2015

Image-based icons would be great.. would be nice to write a local weather script for bar someday. :)

@jangel88
Copy link

@LemonBoy
Ping! Looks like #105 was fixed. Any chance to get this issue resolved now?

@CamilleScholtz
Copy link

ping3 :p

What @jangel88 said.

@LemonBoy
Copy link
Owner

LemonBoy commented Apr 9, 2015

I'll try to give a shot this weekend, I'm super busy lately and I'm also trying to come up with a cairo/pango version of bar that will (eventually) replace this :)

@onodera-punpun I definitely love your avatar :3

@LemonBoy
Copy link
Owner

LemonBoy commented May 8, 2015

A quick heads up, I haven't finished implementing this at the moment, but someone created a nice font that includes a lot of icons [1], you should check it out!

[1] https://github.com/gstk/siji

@eigengrau
Copy link

Glyphicons also make for nice eye candy in the bar :)

@ycny
Copy link

ycny commented Jul 16, 2015

@LemonBoy are you still working on this? :)

@hacktivateit
Copy link

ping @LemonBoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants