Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano S uses uncompressed keys even on Segwit paths #25

Open
oriolpont opened this issue Mar 5, 2018 · 0 comments
Open

Nano S uses uncompressed keys even on Segwit paths #25

oriolpont opened this issue Mar 5, 2018 · 0 comments

Comments

@oriolpont
Copy link

Segwit transactions are supposed to use compressed keys only, and uncompressed ones will be made invalid in the future.

This issue has two sub-issues (probably related) namely:

  • getWalletPublicKey() method always returns public keys in the uncompressed form: \x04+x_coord+y_coord

  • getFirmwareVersion() method says that keys are uncompressed.

dongle = getDongle(True)
app = btchip(dongle)
app.getFirmwareVersion() 

replies that: {'specialVersion': 48, 'version': '1.1.18', 'compressedKeys': False} when used on the official app installed from the manager.

I initialized my Nano S by restoring my BIP39 mnemonic, segwit path, no passwords.

A quick inspection on the generated P2SH-P2WPKH addresses suggests that they indeed correspond to the compressed forms, and in at least one case the wallet spent from a compressed-key associated segwit input, but I have not systematically checked that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant