Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkeryian skies causes framerate to drop to zero when third person is toggled #183

Open
ABSOLUTEMAX123 opened this issue Dec 9, 2024 · 2 comments
Labels
compat 与其他模组兼容性问题 Compatibility issue with other mods

Comments

@ABSOLUTEMAX123
Copy link

Minecraft Version

1.20.1

Mod Version

2.2.0

Mod Loader

Forge

The other mod(s)

Valkerian skies, eureka, and create w/ create:connected

Describe the bug

after making a eureka ship out of Create: connected fluid vessels, i pressed f5 and my frames dropped to zero. on normal ground the frames come back

To Reproduce

after making a eureka ship out of Create: connected fluid vessels, i pressed f5 and my frames dropped to zero. on normal ground the frames come back

Expected behaviour

the mod to work as intended with little to no framerate drops

Additional context

No response

@ABSOLUTEMAX123 ABSOLUTEMAX123 added the compat 与其他模组兼容性问题 Compatibility issue with other mods label Dec 9, 2024
@Bitlod
Copy link

Bitlod commented Dec 29, 2024

Same issue
Ill add that it maybe happening because of create mod himself. When you sitting on a seat, normally the camera moves away so you can see ur creation fully without collisions. Maybe create trying to use default third person feature, but bind(or name of third person mode) was deleted for using only better first person view. Idk, maybe changing name like default-style will fix this, I'm not pro in Java

@dark-steveneq
Copy link

dark-steveneq commented Jan 7, 2025

Same issue, it seems like the custom camera offset is throwing off third person to the point it causes a huge lag i think one good way to fix it is by using the vanilla third person when controlling a ship

Edit: When I swam into my ship my game crashed, here's the relevant stack trace

java.lang.IllegalArgumentException: Minimum cannot be greater than maximum: 63.13234196277335 > 63.132341962715145
	at com.github.leawind.thirdperson.util.math.Zone.<init>(Zone.java:23) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:classloading}
	at com.github.leawind.thirdperson.util.math.Zone.withMax(Zone.java:238) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:classloading}
	at com.github.leawind.thirdperson.core.CameraAgent.limitRotateCenter(CameraAgent.java:208) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:mixin,re:classloading}
	at com.github.leawind.thirdperson.core.CameraAgent.getRotateCenterFinally(CameraAgent.java:250) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:mixin,re:classloading}
	at com.github.leawind.thirdperson.core.CameraAgent.onClientTickStart(CameraAgent.java:268) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:mixin,re:classloading}
	at com.github.leawind.thirdperson.ThirdPersonEvents.onClientTickPre(ThirdPersonEvents.java:85) ~[leawind_third_person-v2.2.0-mc1.20-1.20.1-forge.jar%23329!/:?] {re:classloading}
	at dev.architectury.event.forge.EventHandlerImplClient.event(EventHandlerImplClient.java:56) ~[architectury-9.2.14-forge.jar%23273!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at dev.architectury.event.forge.__EventHandlerImplClient_event_ClientTickEvent.invoke(.dynamic) ~[architectury-9.2.14-forge.jar%23273!/:?] {re:classloading,pl:eventbus:B}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat 与其他模组兼容性问题 Compatibility issue with other mods
Projects
None yet
Development

No branches or pull requests

3 participants