Fixed an issue where we'd randomly fail to load the original DLL. #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
LoadLibraryA
expects a null-terminated string. I noticed this issue withproxygen
and realised it might also be a problem here.This PR simply pushes a null byte to the end of the path passed to
LoadLibraryA
.Additionally, I thought it'd be a good idea to also use
INFO_BUFFER_SIZE
(32767) as the buffer size when getting the current DLL path.Testing
I was able to reproduce it happening once in quite a few launches, and afterwards I was able to launch a few times without it happening. Should be fine.
Fixes #632