fix potential crash

Imrglop · Imrglop · commit 05c544436679 · 2025-03-31T09:10:02.000-04:00
diff --git a/src/sdk/common/client/game/Options.h b/src/sdk/common/client/game/Options.h
@@ -15,11 +15,17 @@ namespace SDK {
 		}
 
 		bool getVsync() {
-			for (auto& option : options) {
-				if (option->impl->id == OptionID::Vsync) {
-					return static_cast<SDK::BoolOption*>(option.get())->value;
+			auto it = std::find_if(options.begin(), options.end(), [](std::unique_ptr<Option>& option) {
+				if (option && option->impl->id == OptionID::Vsync) {
+					return true;
 				}
+				});
+
+			if (it == options.end()) {
+				return false;
 			}
+
+			return static_cast<BoolOption*>(it->get())->value;
 		}
 
 	private:

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,17 @@ namespace SDK {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`bool getVsync() {`
`18`		`- for (auto& option : options) {`
`19`		`- if (option->impl->id == OptionID::Vsync) {`
`20`		`- return static_cast<SDK::BoolOption*>(option.get())->value;`
	`18`	`+ auto it = std::find_if(options.begin(), options.end(), [](std::unique_ptr<Option>& option) {`
	`19`	`+ if (option && option->impl->id == OptionID::Vsync) {`
	`20`	`+ return true;`
`21`	`21`	`}`
	`22`	`+ });`
	`23`	`+`
	`24`	`+ if (it == options.end()) {`
	`25`	`+ return false;`
`22`	`26`	`}`
	`27`	`+`
	`28`	`+ return static_cast<BoolOption*>(it->get())->value;`
`23`	`29`	`}`
`24`	`30`
`25`	`31`	`private:`