Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Aftermath effect cleanup #5820

Closed
wants to merge 2 commits into from

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 22, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closes #5231 .

Changes aftermath to encode the aftermath effect the same way on a pet:

  • ensure we always give the effect to the pet with the same power/subpower/tier/duration

This then allows us to simplify the onEffectGain/onEffectLose functions to just stack mods on the effect

Steps to test these changes

see that pet gets the mods just like before
image

and also that aftermath functions the same for player as well:
image

and just to be sure here's spharai:
image
image

and of course there are no errors in map server console

@MowFord MowFord closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Lua script error: Final Heaven WS: onEffectLose: expected number, received nil
1 participant