Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] Update pet buffs to set themselves as initial target for AoEs #5818

Closed
wants to merge 1 commit into from

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 22, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

AoE petskills weren't including the pet itself, this PR fixes that. Closes #4996 .

Steps to test these changes

To show that it doesn't target party-member's pets:
https://imgur.com/G5TaRBE

and here's the message showing up properly like retail:
image

Suspected the primary target message is what made the text color slightly different, confirmed:
image

@MowFord MowFord closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [SMN] BP: Ward pet_skills rework does not consider the pet as a target
1 participant