Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming related to RenderTarget/RenderTargetLayer between SFML and SDL binding #301

Open
Laguna1989 opened this issue Nov 2, 2023 · 1 comment

Comments

@Laguna1989
Copy link
Owner

Needs to be analyzed and named consistently. SDL and SFML work very differently under the hood, so this might cause some ripples throughout the jamtemplate

@Laguna1989
Copy link
Owner Author

One starting point might be the GfxImpl class.

  • SFML calls m_window.createRenderTarget() (which returns a RenderTargetLayer, which is a sf::RenderTexture) in GfxImpl::createZLayer()
  • SDL calls m_window.createRenderTarget() (which returns a RenderTargetLayer, which is a SDLRenderer) in the constructor.

Basically RenderTargetLayer means different things in SDL and SFML binding. This is inconsistent and should be reworked.

@Laguna1989 Laguna1989 reopened this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant