Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define dataset types with rail.plotting, i.e., structures that can be used to make particular plots. #18

Open
eacharles opened this issue Feb 5, 2025 · 0 comments
Assignees

Comments

@eacharles
Copy link
Collaborator

Right now RailPlotter classes define a dict of types, using inputs: dict = {} and check that the data matches the types.

RailProjectDataExtractor classes define a different dict of types, also using inputs: dict = {} to check that that they are being called with the correct inputs, and return a dict of data, which should match RailPlotter.dict(), but that isn't enforced.

RailDatasetHolder classes define extractor_inputs, which should match RailProjectDataExtractor.inputs, and enforce that, but do not enforce that they return a particular type of output data.

It would be good the enforce this, and to use names to match the types, so that we can quickly see which RailPlotters go with which RailProjectDataExtractor

@eacharles eacharles self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant