Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "layering" mode to allow users to add objects to already simulated fields. #109

Open
cwwalter opened this issue Apr 21, 2018 · 5 comments

Comments

@cwwalter
Copy link
Member

cwwalter commented Apr 21, 2018

Recently @kadrlica did some dark matter work where he and others simulated a ultra-diffuse galaxy on a pre-existing field by generating the sources he needed with no sky or instrumental background and adding the resulting images to the background image.

With the recent checkpointing code added by @jchiang87 it is always now possible to start accumulating photons on an existing exposure.

As an enhancement, it might be nice in the future to add an official "layering" mode where the user could specify an existing image which already included the sky and other sources and an instance catalog of new sources to simulate.

This way people could take (for example) a subset of imSim DC2 images and then layer/add whatever sorts of sources they wanted to them for specialized studies as Alex did above. This could even be used for small manual sprinkler type studies where a (e.g.) time varying SN was added to a host galaxy in an image. The same base image could be used for each exposure and it would be very fast to add the magnitude varying SN to each one.

@kadrlica
Copy link

Seems like a cool idea. The way that I did it was just to use the top level instCat specifications for the telescope pointing, orientation, and other environmental factors, and then swap in my object list for the original imported object list. I was actually mixing phosim "background" with an imsim "front layer", which I guess has it's pluses and minuses. Unless there is something obviously wrong with this procedure, it seems easy enough that no further development is needed for my specific application.

@cwwalter
Copy link
Member Author

cwwalter commented Mar 9, 2020

@jchiang87 Did the changes that allowed us to turn of the sky also allow the user to specify a preexisting image to draw on. I think 'no' but wanted to double check. (I know this is possible via manipulating checkpoints.)

@cwwalter cwwalter added this to the imSim 2.1 milestone Aug 15, 2023
@cwwalter
Copy link
Member Author

I wanted to ping this old issue to surface it.

This is something we effectively did do before in with the checkpoints to layer on transient objects. This has come up again in the context of both the Roman-Rubin simulations and implementing things like SSI.

Mike and I talked about this at the PCW and I he also mentioned he had a way he was interested in doing this.

@rmjarvis
Copy link
Contributor

This will be easier in GalSim 2.5. I have a solution in progress. The gist is that we will be able to add an initial_image input item that reads in an existing image file and then add things to it.

@rmjarvis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants