Improvement: Small Fixes and Correcting Faulty Chapter Logic #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagami
reviewed
Mar 22, 2025
|
|
||
| const markPreviousChaptersUnreadQuery = | ||
| 'UPDATE Chapter SET `unread` = 1 WHERE id <= ? AND novelId = ?'; | ||
| 'UPDATE Chapter SET `unread` = 1 WHERE id >= ? AND novelId = ?'; |
Member
There was a problem hiding this comment.
why >=, isnt previous chapter id is smaller than the selected chapter id
Contributor
Author
There was a problem hiding this comment.
Because as it is right now it makes no sense. If you read 30 chapters of a novel and you want to select chapter 15 and previous ones as unread, you don't want to mark chapters 1-15 unread but 15-30. It's kind of reversed logic from marking previous chapters read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.