Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve permuted layout/view construction #1751

Open
artv3 opened this issue Oct 10, 2024 · 0 comments
Open

Improve permuted layout/view construction #1751

artv3 opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
API/usability Enhancement reviewed Mark with this label when issue has been discussed by team

Comments

@artv3
Copy link
Member

artv3 commented Oct 10, 2024

Is your feature request related to a problem? Please describe.

Constructing a permuted layout can be cumbersome. For example the following will create a permuted layout and identify unit stride.

std::array<RAJA::idx_t, 3> perm3a {{2, 1, 0}};                                                                                                                                                                                           
RAJA::Layout< 3, int> perm3a_layout =                                                                                                                                                                                                    
RAJA::make_permuted_layout( {{Nx, Ny, Nz}}, perm3a);                                                                                                                                                                                   
RAJA::View< int, RAJA::Layout<3, int, 0> > perm3a_view_3D(a, perm3a_layout);

Experiments have shown that specifying unit stride on the Layout used when making a permuted layout object does not effect index calculation only the one in the View.

Describe the solution you'd like

A simpler approach to constructing such a view

@artv3 artv3 changed the title Improve permuted layout construction Improve permuted layout/view construction Oct 10, 2024
@rhornung67 rhornung67 added API/usability Enhancement reviewed Mark with this label when issue has been discussed by team labels Oct 15, 2024
@rhornung67 rhornung67 added this to the FY25 Development milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API/usability Enhancement reviewed Mark with this label when issue has been discussed by team
Projects
None yet
Development

No branches or pull requests

2 participants