Drop daemonizing logic #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Hugo. As mentioned in #182, could you maybe also delete the |
WhyNotHugo
force-pushed
the
main
branch
3 times, most recently
from
0389f02
to
a0dd6ee
Compare
Rely on `swww-daemon` instead. It runs in foreground, which is what service managers expect. Usages like running `exec swww` in sway's config continue to work fine. User session start-up scripts can simply run `swww-daemon &`. Fixes: LGFae#182
WhyNotHugo
commented
Jun 7, 2024
Comment on lines
-24
to
-39
| match is_daemon_running() { | ||
| Ok(false) => { | ||
| let socket_path = get_socket_path(); | ||
| if socket_path.exists() { | ||
| eprintln!( | ||
| "WARNING: socket file {} was not deleted when the previous daemon exited", | ||
| socket_path.to_string_lossy() | ||
| ); | ||
| if let Err(e) = std::fs::remove_file(socket_path) { | ||
| return Err(format!("failed to delete previous socket: {e}")); | ||
| } | ||
| } | ||
| } | ||
| Ok(true) => { | ||
| return Err("There seems to already be another instance running...".to_string()) | ||
| } |
There was a problem hiding this comment.
I think I actually need to move this logic into the daemon, right?
LGFae
reviewed
Jun 7, 2024
Comment on lines
220
to
+221
| Importantly, **cache will only be loaded during initialization if you use swww | ||
| init**. That is, calling `swww-daemon` directly will **NOT** load the cache, but | ||
| calling `swww-init` will. | ||
| init**. That is, calling `swww-daemon` directly will **NOT** load the cache. |
There was a problem hiding this comment.
Ah, this isn't true anymore. swww-daemon loads the cache now, unless you pass it the --no-cache flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run in foreground, which is what service managers expect. Usages like running
exec swwwin sway's config continue to work fine. User session start-up scripts can simply runswww &.Fixes: #182