Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make detector volume checks in DetectorConstruction visible to other classes #1286

Open
tvami opened this issue Apr 18, 2024 · 1 comment
Open

Comments

@tvami
Copy link
Contributor

tvami commented Apr 18, 2024

Is your feature request related to a problem? Please describe.

The functions in https://github.com/LDMX-Software/SimCore/blob/trunk/src/SimCore/DetectorConstruction.cxx
like isInEcal, isInHcal, isInTargetRegion, etc are under the namespace logical_volume_tests that's defined in the cxx file only. That means they are not visible to any other class. These functions could be useful especially when we are doing different biasing.

Describe the solution you'd like

Declare them in the header of DetectorConstruction

Describe alternatives you've considered

Put them into their own header/source to separate them from their use in detector construction.
--> But I think it's ok to reuse them, like this we'll have a smaller code base

Additional context

Came up here #1285 (comment)

@EinarElen
Copy link
Contributor

I would probably favour the second option of having a separate translation unit for tools like this if they are useful elsewhere. I would at least be a bit surprised if I saw the detectorconstruction header includes in other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants