more robust error handling

Author: FerencBodon-Kx

README.md

@@ -65,10 +65,11 @@ The environment executing this test must have the associated cloud vendor CLI se
 
 You can also test the [cache](https://code.kx.com/insights/1.4/core/objstor/kxreaper.html) impact of the object storage library. The recommended way is to
    * provide an object storage path in `partitions`
-   * run a full test to populate data: `./mthread.sh $(nproc) full keep`. Take note of the data location postfix (`0509D1529` in our case)
+   * `DATE=$(date +%m%d_%H%M%S)`
+   * run a full test to populate data: `./mthread.sh $(nproc) full keep $DATE`.
    * assign an empty directory on a fast local disk to the environment variable `KX_OBJSTR_CACHE_PATH` in file `./config/env`
-   * run the test to populate cache: `./mthread.sh $(nproc) readonly keep 0509D1529`
-   * run the test again to use cache: `./mthread.sh $(nproc) readonly delete 0509D1529`
+   * run the test to populate cache: `./mthread.sh $(nproc) readonly keep $DATE`
+   * run the test again to use cache: `./mthread.sh $(nproc) readonly delete $DATE`
    * delete cache files in object storage cache: `source ./config/env; rm -rf ${KX_OBJSTR_CACHE_PATH}/objects`
 
 The random read kdb+ script is deterministic, i.e. it reads the same blocks in consecutive runs. The script uses [roll](https://code.kx.com/q/ref/deal/#roll-and-deal) for selecting random blocks which uses a fixed seed.

mthread.sh

@@ -59,6 +59,21 @@ declare -a array
 array=($(cat $PARFILE))
 readonly NUMSEGS=${#array[@]}
 
+if [ $SCOPE = "readonly" ]; then
+  if ! [ "$#" -eq "4" ]; then
+    echo "Passing a date (4th) parameter is mandatory in readonly mode to locate previously generated data files"
+    exit 5
+  fi
+  j=0
+  for i in $(seq $NUMPROCESSES); do
+  	if ! [ -d ${array[$j]}/${HOST}.${i}/${DATE} ]; then
+      echo "Data directory ${array[$j]}/${HOST}.${i}/${DATE} does not exits. Mode readonly assumes that data has been generated previously."
+      exit 6
+    fi
+    j=$(( ($j + 1) % $NUMSEGS ))
+  done
+fi
+
 readonly RESDIR="${RESULTDIR}/${DATE}"
 mkdir -p ${RESDIR}
 echo "Results will be persisted in ${RESDIR}"
@@ -163,7 +178,7 @@ trap cleanup EXIT
 j=0
 for i in $(seq $NUMPROCESSES); do
   if notObjStore ${array[$j]}; then
-    if [ -d ${array[$j]}/${HOST}.${i} ]; then
+    if [ $SCOPE = "full" ] && [ -d ${array[$j]}/${HOST}.${i} ]; then
       echo "${array[$j]}/${HOST}.${i} directory already exists. Please remove it and rerun."
       exit 7
     fi

src/controller.q

@@ -31,7 +31,7 @@ getKBRead: $[.z.o ~ `m64; getKBReadMac; getKBReadLinux]
 
 finish: {[x:`j]
   .qlog.info "Sending exit message to workers";
-  @[; "exit 0"; ::] each Workers;
+  @[; "exit ", string x; ::] each Workers;
   exit x
   }
 

version.yaml

@@ -1,2 +1,2 @@
-pub: 3.4.0
-dev: 3.4.0
+pub: 3.4.1
+dev: 3.4.1