KXI-61418 properly handling disks without partitions

Author: FerencBodon-Kx

.gitlab-ci.yml

@@ -60,15 +60,18 @@ docker-builddev-push:
   needs:
     - job: docker-builddev-push
   variables:
-    APPDIR: /opt/kx/app
     QLIC: /tmp/qlic
   before_script:
     - mkdir -p "$QLIC"
     - echo -n "$KDB_LICENSE_B64" | base64 -d > "$QLIC/kc.lic"
-    - cd ${APPDIR}
     - source ./config/env
   rules:
     - if: '$CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH'
+  artifacts:
+    paths:
+      - logs/*/*.log
+    expire_in: 1 day
+    when: on_failure
 
 mthread-single:
   extends:

src/common.q

@@ -24,7 +24,7 @@ controller: `$"::",argv `controller;
 
 msstring:{(string x)," ms"}
 // df returns partition like /dev/nvme0n1p1
-getPartition: {[db:`C] first " " vs last system "df ", db}
+getFilesystem: {[db:`C] first " " vs last system "df ", db}
 
 getDeviceOSX:{
   $[1 = count system "diskutil list|grep physical";
@@ -36,7 +36,10 @@ getDeviceOSX:{
 getDevice:{[db:`C]
   if[.z.o=`m64;:getDeviceOSX[]];
 
-  p: ssr[;"/dev/";""] getPartition[db];
+  fs: getFilesystem[db];
+  if["overlay" ~ fs; :fs];   / Inside Docker, NYI
+  if["disk" ~ last system "lsblk -o type ", fs; :fs];
+  p: ssr[;"/dev/";""] fs;
   // disk is looked up from partition by e.g. /sys/class/block/nvme0n1p1
   if[not (`$p) in key `$":/sys/class/block";
     .qlog.warn "Unable to map partition ", p, " to a device";

version.yaml

@@ -1,2 +1,2 @@
-pub: 3.3.0
-dev: 3.3.0
+pub: 3.3.1
+dev: 3.3.1