Channels compat #347
Closed
Channels compat #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrbnlulu
commented
Aug 4, 2022
| @@ -3,7 +3,7 @@ repos: | |||
| rev: 22.6.0 | |||
| hooks: | |||
| - id: black | |||
| language_version: python3.9 | |||
| language_version: python3.10 | |||
There was a problem hiding this comment.
You can revert this when merged, I don't have python 3.9. If you insist I can download.
| @@ -110,8 +111,17 @@ def resolve(self, _next, root, info: GraphQLResolveInfo, *args, **kwargs): | |||
| return _next(root, info, **kwargs) | |||
|
|
|||
|
|
|||
| def channels_compat(context: StrawberryChannelsContext) -> None: | |||
There was a problem hiding this comment.
I wouldn't put that in utils since it is used only here. This is a function for readability.
| class AsyncJSONWebTokenMiddleware(BaseJSONWebTokenMiddleware): | ||
| async def resolve(self, _next, root, info: GraphQLResolveInfo, *args, **kwargs): | ||
| if isinstance(info.context, StrawberryChannelsContext): |
There was a problem hiding this comment.
I think that is the first entry point as far as our concerns am I right? Also this is not in BaseJSONWebTokenMiddleware since channels won't use sync schema.
|
Things to discuss here:
|
nrbnlulu
commented
Aug 11, 2022
…a extension's `resolve` not called while running `schema.subscribe`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR resolves #346
tests will be added when the channels pr will be merged.