Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom DownloadUrl #211

Open
chdanielmueller opened this issue Sep 8, 2020 · 1 comment
Open

Custom DownloadUrl #211

chdanielmueller opened this issue Sep 8, 2020 · 1 comment

Comments

@chdanielmueller
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request

As per #183 (comment)

Current behavior

Calling modalGalleryService.open with the option config.libConfig.currentImageConfig.downloadable: true results in a download button on the page which downloads the file specified in modal.img

Expected behavior

It would be great that the download button downloads the "extUrl" or another property than "img".
Maybe a "downloadUrl" property which takes priority over img when specified.

What is the motivation / use case for changing the behavior?

The reason behind this is that we show a resized image on the Webapp and allow the download of the full sized image.

Environment (the most important section to fill very carefully)


- @ks89/angular-modal-gallery version: 8.0.0-beta.4
- Node version: 12.14.1  
- npm version: 6.14.5  
- Operating System and version: macOS 10.15.6 
- Angular version: 9.1.11 
- angular-cli version (or SystemJS/Webpack): 9.1.9 
- I'm using Server Side Rendering with angular-universal: NO
- I'm compiling with mode: PROD with AOT



Browser:
- [ ] Chrome (desktop) version 85.0.4183.83

Others:

@Ks89
Copy link
Owner

Ks89 commented Sep 9, 2020

good idea to create a dedicated issue

@Ks89 Ks89 modified the milestone: next Sep 9, 2020
@Ks89 Ks89 self-assigned this Sep 9, 2020
@Ks89 Ks89 modified the milestones: next, 10.0.0 Jul 10, 2021
@Ks89 Ks89 modified the milestones: 11.0.0, next Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants