Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fzf reverse search doesn't work when activated from shell mode #318

Open
jonniediegelman opened this issue Apr 11, 2023 · 3 comments
Open

Comments

@jonniediegelman
Copy link

I work in shell mode of the REPL pretty often and I have to exit out of shell mode to get the nice fzf version of reverse search. It is especially annoying when the thing I'm reverse-searching for is a shell command I executed.

@Moelf
Copy link
Contributor

Moelf commented Apr 11, 2023

it also doesn't work in pkg> , basically we only inject keybinding into REPL mode rn

@jonniediegelman
Copy link
Author

Would it be worth me submitting a PR to inject just the ^R keybinding in the pkg, help, and shell modes? Or is this something not desired in general?

@Moelf
Copy link
Contributor

Moelf commented Apr 11, 2023

I'm not against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants