Add more vertical spacing to KLib dumps #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
commented
May 6, 2024
src/functionalTest/resources/examples/classes/TopLevelDeclarations.klib.all.dump
Show resolved
Hide resolved
fzhinkin
force-pushed
the
197-consider-decl-kind-when-sorting-dump
branch
from
a9a5b5a
to
41770eb
Compare
fzhinkin
force-pushed
the
196-add-more-vertical-spacing
branch
2 times, most recently
from
fa9bbe7
to
e8b4f6c
Compare
ilya-g
approved these changes
Jun 10, 2024
fzhinkin
changed the base branch from
197-consider-decl-kind-when-sorting-dump
to
develop
fzhinkin
force-pushed
the
196-add-more-vertical-spacing
branch
from
e8b4f6c
to
512b45b
Compare
ALikhachev
added a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Jul 23, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes.
ALikhachev
added a commit
to Kotlin/kotlinx-benchmark
that referenced
this pull request
Jul 23, 2024
Also, update the dump to reflect the actual state of the Gradle plugin. Reorders entries in the dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 Removes internal constants from the dump: Kotlin/binary-compatibility-validator#90 Fixes #248
sandwwraith
pushed a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Jul 23, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes.
sandwwraith
pushed a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Aug 1, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes. Cherry-picked from 46f406d
sandwwraith
added a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Aug 5, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes. Cherry-picked from 46f406d Co-authored-by: Alexander Likhachev <[email protected]>
woainikk
pushed a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Aug 7, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes.
woainikk
added a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Aug 7, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes.
qurbonzoda
pushed a commit
to Kotlin/kotlinx-benchmark
that referenced
this pull request
Aug 15, 2024
Also, update the dump to reflect the actual state of the Gradle plugin. Reorders entries in the dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 Removes internal constants from the dump: Kotlin/binary-compatibility-validator#90 Fixes #248
woainikk
pushed a commit
to Kotlin/kotlinx.serialization
that referenced
this pull request
Aug 26, 2024
This is required to ensure compatibility of the build with Kotlin 2.1+ after resolving https://youtrack.jetbrains.com/issue/KT-61706 Adds kotlinx-serialization-json-tests to ignored projects: Kotlin/binary-compatibility-validator#243 Reorders entries in dumps: Kotlin/binary-compatibility-validator#225, Kotlin/binary-compatibility-validator#196 The entries are only reordered, but contain no significant changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional newlines should improve dump's readability and also improve diffs generated by the GH.
This change builds on #197, which groups declarations based on their kind.
Now, an extra newline will always be inserted before:
// Targets:meta-header,varsandfuns).Closes #196