Make Klib-related Gradle tasks public #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
force-pushed
the
make-tasks-public
branch
from
e94154b
to
bb48561
Compare
Base automatically changed from
199-disable-tasks-for-empty-projects
to
develop
March 27, 2024 14:36
fzhinkin
force-pushed
the
make-tasks-public
branch
from
bb48561
to
25efc08
Compare
fzhinkin
force-pushed
the
make-tasks-public
branch
from
25efc08
to
5a03695
Compare
shanshin
reviewed
May 13, 2024
fzhinkin
force-pushed
the
make-tasks-public
branch
from
2b7b900
to
4de527a
Compare
shanshin
reviewed
Jun 19, 2024
Also, reworked error reporting for the compare task.
- SyncFile is no longer cachable - removed KotlinApiCompareTask's ctor
fzhinkin
force-pushed
the
make-tasks-public
branch
from
8b0f562
to
d8271ab
Compare
shanshin
approved these changes
Jun 21, 2024
| import org.gradle.api.tasks.Input | ||
| import org.gradle.api.tasks.Internal | ||
| import org.gradle.api.tasks.OutputFile | ||
| import java.io.File | ||
|
|
||
|
|
||
| public abstract class BuildTaskBase : DefaultTask() { |
There was a problem hiding this comment.
Should we link a public task so tightly to a specific extension?
There was a problem hiding this comment.
These tasks are tightly bound to BCV anyway. The thing that worries me more is implicit initialization of properties, but I'm not sure that making initialization explicit and moving it to BinaryCompatibilityValidatorPlugin will make a big difference for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
Fixed #203