Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KLib validation related tasks public #203

Closed
fzhinkin opened this issue Mar 25, 2024 · 1 comment · Fixed by #204
Closed

Make KLib validation related tasks public #203

fzhinkin opened this issue Mar 25, 2024 · 1 comment · Fixed by #204
Assignees
Labels
enhancement New feature or request klib

Comments

@fzhinkin
Copy link
Collaborator

Currently, all tasks required for klib validation are internal.

We should make these tasks public (and cleanup the API along the way), so those who can't directly apply our plugin could incorporate them into custom plugins without writing identical tasks using programmatic API.

@fzhinkin fzhinkin added enhancement New feature or request klib labels Mar 25, 2024
@fzhinkin fzhinkin self-assigned this Mar 25, 2024
@fzhinkin fzhinkin added this to the klib/0.15.0-Beta.3 milestone Mar 26, 2024
@fzhinkin fzhinkin linked a pull request Mar 27, 2024 that will close this issue
@aSemy
Copy link
Contributor

aSemy commented Mar 28, 2024

Would you consider splitting them out into a separate subproject? It would help with making the Gradle Plugin more idiomatic, being able to test them in isolation, and keeping user's build script classpaths cleaner.

Currently BCV leaks all its dependencies required for KLib validation into the build script classpath, but the KLib validation is only required during task execution, not during build configuration.

UPDATE Never mind, I misread. I thought this issue was about making the kotlinx.validation.api.klib.* classes public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request klib
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants