Skip to content

Wrap KonnectGatewayControlPlane ControlPlaneSpec into a dedicated field #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
mlavacca opened this issue Apr 8, 2025 · 0 comments
Open
1 task

Comments

@mlavacca
Copy link
Member

mlavacca commented Apr 8, 2025

Problem Statement

With the addition of the mirror KonnectGatewayControlPlanes, we had to introduce plenty of CEL rules to validate that no origin-related field is set in case the type is mirror.

Proposed Solution

We need to wrap the original ControlPlaneSpec field into a dedicated originSpec field.

Additional Information

This is a breaking change in the KonnectGatewayControlPlane CRD. we need to evaluate whether to have a conversion webhook in place to avoid disruption is users' configurations.

Acceptance Criteria

  • The origin-related fields are wrapped into a dedicated spec field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant