Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure threshold for "Response over 5MB hidden for performance reasons" message #3115

Open
mxmlnglt opened this issue Feb 24, 2021 · 11 comments · May be fixed by #6520
Open

Configure threshold for "Response over 5MB hidden for performance reasons" message #3115

mxmlnglt opened this issue Feb 24, 2021 · 11 comments · May be fixed by #6520
Labels
C-improvement Category: Improvement / Enhancement E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer

Comments

@mxmlnglt
Copy link

Hello,

Found this old issue #412 that mentioned displaying large JSON data, linked to this commit c4933ba limiting displaying data larger than 5MB i.e. when you see this message: "Response over 5MB hidden for performance reasons".

However, for performance testing, I'd like to lower this threshold?

Is it possible?

@nijikokun nijikokun added feature request E-good-first-issue Experience required: Beginner / New labels Mar 1, 2021
@Warkanlock
Copy link

I modify threshold to 2MB which is a good threshold in my opinion, you can try it there but let's see what's dev team opinion here

@mxmlnglt
Copy link
Author

er... but this is hard-coded!?

@Warkanlock
Copy link

I think I misunderstood the issue. But before was 5 on the config files and I change to 2MB. We want this reduce of threshold only happens when someone is testing?

@mxmlnglt
Copy link
Author

I want to configure it, I want to put my own value, be it 1 MB or 3 MB or 300 kB.

@stale
Copy link

stale bot commented May 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mxmlnglt
Copy link
Author

I'm still looking forward to it...

@mxmlnglt
Copy link
Author

why what is tagged with "feature-request" then marked as "wontfix" and "closed-by-team"... by a bot?! @nijikokun any idea?

@mxmlnglt
Copy link
Author

Note: also there's a related PR pending: #3189 but that doesn't really solve the problem, as confirmed by @dimitropoulos

@dimitropoulos dimitropoulos reopened this Aug 31, 2021
@dimitropoulos
Copy link
Contributor

@mxmlnglt sorry about that. we've since removed the bot that closed this issue (altogether) because of (among other reasons) how many "false positive" closures (just like this) we experienced.

Lemme know how I can be of help if you or anyone else is working on a PR for this.

@mxmlnglt
Copy link
Author

In January, @alirezaalavi87 asked if he could contribute, and if someone could help him start, but I can't find his message here...

@filfreire filfreire added C-improvement Category: Improvement / Enhancement S-verified Status: Verified by maintainer and removed closed-by-team labels Jul 25, 2022
@jason-karuza-afresh
Copy link

Agreed that this would be nice

@ThalisonCosta ThalisonCosta linked a pull request Sep 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: Improvement / Enhancement E-good-first-issue Experience required: Beginner / New S-verified Status: Verified by maintainer
Projects
None yet
6 participants