Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Websockets endpoints. #18

Open
KmiQ opened this issue Mar 4, 2023 · 5 comments
Open

Implement Websockets endpoints. #18

KmiQ opened this issue Mar 4, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@KmiQ
Copy link
Owner

KmiQ commented Mar 4, 2023

    It is definitely the latter. It's already the basis of a couple of personal applications. As the repo continues having improvements, I guess it can better serve others with their projects as well.

I agree WebSocket endpoints and rate limiting on all requests are good things to add. Let's add issues to track it.

Originally posted by @KmiQ in #17 (comment)

@KmiQ KmiQ added the enhancement New feature or request label Mar 4, 2023
@gunjack-el
Copy link
Contributor

Hello @KmiQ, any news about this feature?

@KmiQ
Copy link
Owner Author

KmiQ commented Apr 29, 2024

Hello @KmiQ, any news about this feature?

hey @gunjack-el . No updates here, unfortunately, BUT if you want to give it a try, I'd be more than happy to review it and provide support.

@gunjack-el
Copy link
Contributor

I have almost implemented the entire feature. I would kindly like a review to ensure it aligns with your coding style.

@KmiQ
Copy link
Owner Author

KmiQ commented Jul 5, 2024

I have almost implemented the entire feature. I would kindly like a review to ensure it aligns with your coding style.

Thank you @gunjack-el . Sure thing, feel free to open a PR and I'm gonna review it for you.

@gunjack-el
Copy link
Contributor

PR requested ;)
For any clarification, I am at your complete disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants