-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage with practical data sets #188
Comments
@dzenanz has some test data for spectral data. |
To that point, we already host/include liver spectra samples for attenuation testing (see data.kitware.com). @dzenanz should I amend this issue to reflect adding |
Yes, testing on that sample data would be good. Those two filters were recently added, I doubt more filters need extra testing. But Phantom RF data could be used as start of chain of filters: |
Several ultrasound image filters rely on contrived data for CTest coverage. For example,
Spectra1DAveragingImageFilter
tests currently average over multiple copies of a single image,spectra_pixel_image.mha
, which depicts a 3D image with a single 31-channel pixel. In this case limited test data failed to cover an issue with stepping over lines, leading to the patch in #187.It would be useful to revisit our testing and potentially duplicate some image filter tests with a small variety of input data samples representing real-world cases.
The text was updated successfully, but these errors were encountered: