Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage with practical data sets #188

Open
tbirdso opened this issue Mar 17, 2022 · 4 comments
Open

Improve test coverage with practical data sets #188

tbirdso opened this issue Mar 17, 2022 · 4 comments

Comments

@tbirdso
Copy link
Contributor

tbirdso commented Mar 17, 2022

Several ultrasound image filters rely on contrived data for CTest coverage. For example, Spectra1DAveragingImageFilter tests currently average over multiple copies of a single image, spectra_pixel_image.mha, which depicts a 3D image with a single 31-channel pixel. In this case limited test data failed to cover an issue with stepping over lines, leading to the patch in #187.

It would be useful to revisit our testing and potentially duplicate some image filter tests with a small variety of input data samples representing real-world cases.

@thewtex
Copy link
Member

thewtex commented Mar 17, 2022

@dzenanz has some test data for spectral data.

@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 17, 2022

To that point, we already host/include liver spectra samples for attenuation testing (see data.kitware.com). @dzenanz should I amend this issue to reflect adding Spectra1DAveragingImageFilter and Spectra1DNormalizeImageFilter tests on sample data? Are there any other tests you are aware of that should be expanded?

@dzenanz
Copy link
Member

dzenanz commented Mar 17, 2022

Yes, testing on that sample data would be good. Those two filters were recently added, I doubt more filters need extra testing.

But Phantom RF data could be used as start of chain of filters: Spectra1DSupportWindowImageFilter+Spectra1DImageFilter -> Spectra1DAveragingImageFilter. Then apply Spectra1DNormalizeImageFilter to liver data using output of Spectra1DAveragingImageFilter as reference for normalization.

@tbirdso
Copy link
Contributor Author

tbirdso commented Mar 18, 2022

@dzenanz I've added #189 as a sanity check applying averaging and normalization separately to practical data. I agree that the workflow you've suggested here would make a good integration test, especially in light of recent discussion around spectra image issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants