Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tronApp missing failures more obvious that's the reason #5789

Open
lf94 opened this issue Mar 13, 2025 · 0 comments
Open

Make tronApp missing failures more obvious that's the reason #5789

lf94 opened this issue Mar 13, 2025 · 0 comments
Labels
tests Pull requests that update or improve our test suite

Comments

@lf94
Copy link
Contributor

lf94 commented Mar 13, 2025 

          It appears we can https://playwright.dev/docs/api/class-test#test-fail but unfortunately tronApp is optional so we can't just leave it out in some cases and in, in others, otherwise Playwright will complain and not run at all.

We could do a follow up maybe.

In those tests though, tronApp is a necessary component, so if it's falsey / undefined, it should really fail immediately

Could we leave that for a follow-up for Jace? I'll create an issue

Originally posted by @lf94 in #5680 (comment)
@lf94 lf94 added the tests Pull requests that update or improve our test suite label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Pull requests that update or improve our test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lf94