You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We display default planes in new/empty scenes to give the user some kind of 3d reference since there's nothing else to look at.
The problem is that the way we detect this I think is if the artifactGraph is empty, and when there's an error the artifactGraph is empty (caveat, this might change with keep-on-trucking-execution). So I think the trigger for showing the default planes needs to be sceneIsEmpty && noErrors.
Here's an example of a model where the planes show when they probably should not (if you change the fillet at the bottom to radius = 0.1 than the error goes away)
A good place to start looking is in part of the xstate diagram
search for { type: 'Artifact graph populated' } in the codebase
We display default planes in new/empty scenes to give the user some kind of 3d reference since there's nothing else to look at.
The problem is that the way we detect this I think is if the artifactGraph is empty, and when there's an error the artifactGraph is empty (caveat, this might change with keep-on-trucking-execution). So I think the trigger for showing the default planes needs to be
sceneIsEmpty && noErrors
.Here's an example of a model where the planes show when they probably should not (if you change the fillet at the bottom to
radius = 0.1
than the error goes away)A good place to start looking is in part of the xstate diagram
search for
{ type: 'Artifact graph populated' }
in the codebaseThe text was updated successfully, but these errors were encountered: