Pipes with bend radii #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also related to a discord discussion see this thread |
|
@jgomez720 @greg-kcio opinions on merging this without a proper hole through the pipe |
The code is clean but I think we should wait to include it until it produces a proper pipe with hole. |
|
Agree with Greg. Someone could export a STEP of this and use shell to create the official pipe, but we are asking for too much on the users end imo |
…radii # Conflicts: # screenshots/80-20-rail.png # screenshots/a-parametric-bearing-pillow-block.png # screenshots/ball-bearing.png # screenshots/bracket.png # screenshots/brake-caliper.png # screenshots/car-wheel-assembly.png # screenshots/car-wheel.png # screenshots/enclosure.png # screenshots/flange-with-patterns.png # screenshots/flange-xy.png # screenshots/focusrite-scarlett-mounting-bracket.png # screenshots/french-press.png # screenshots/gear-rack.png # screenshots/gear.png # screenshots/hex-nut.png # screenshots/kitt.png # screenshots/lego.png # screenshots/lug-nut.png # screenshots/mounting-plate.png # screenshots/multi-axis-robot.png # screenshots/pipe-flange-assembly.png # screenshots/pipe.png # screenshots/poopy-shoe.png # screenshots/router-template-slate.png # screenshots/sheet-metal-bracket.png # screenshots/socket-head-cap-screw.png # screenshots/tire.png # screenshots/washer.png # screenshots/wheel-rotor.png # step/80-20-rail.step # step/enclosure.step # step/focusrite-scarlett-mounting-bracket.step # step/mounting-plate.step # step/sheet-metal-bracket.step
…radii # Conflicts: # screenshots/80-20-rail.png # screenshots/a-parametric-bearing-pillow-block.png # screenshots/ball-bearing.png # screenshots/bracket.png # screenshots/brake-caliper.png # screenshots/car-wheel-assembly.png # screenshots/car-wheel.png # screenshots/enclosure.png # screenshots/flange-with-patterns.png # screenshots/flange-xy.png # screenshots/focusrite-scarlett-mounting-bracket.png # screenshots/french-press.png # screenshots/gear-rack.png # screenshots/gear.png # screenshots/hex-nut.png # screenshots/kitt.png # screenshots/lego.png # screenshots/lug-nut.png # screenshots/mounting-plate.png # screenshots/multi-axis-robot.png # screenshots/pipe-flange-assembly.png # screenshots/pipe.png # screenshots/poopy-shoe.png # screenshots/router-template-slate.png # screenshots/sheet-metal-bracket.png # screenshots/socket-head-cap-screw.png # screenshots/tire.png # screenshots/washer.png # screenshots/wheel-rotor.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sample which creates a parameterized pipe bend. However the interior hole is not being respected when revolving the sketch.
See this issue