Skip to content

Commit af78007

Browse files
authored
Conform to PEP8
1 parent 542cc5f commit af78007

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

tests/packet/test_fields.py

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,98 +1,93 @@
11
import pytest
2+
23
from pyshark.packet.fields import LayerField, LayerFieldsContainer
34

45
# Unit Tests - Layer Fields
5-
# **************************************************************************
66
def test_layer_field_hide():
77
hide_yes = LayerField(hide="yes")
88
hide_not_yes = LayerField(hide="not yes")
9-
assert(hide_yes.hide == True and hide_not_yes.hide == False)
9+
assert hide_yes.hide == True and hide_not_yes.hide == False
1010

1111
def test_layer_field_print_format():
1212
name = "test_name"
1313
show = "test"
1414
test_layer_field = LayerField(name=name, show=show)
1515
str_layer_field = test_layer_field.__repr__()
16-
assert(str_layer_field == f'<LayerField {name}: {show}>')
16+
assert str_layer_field == f'<LayerField {name}: {show}>'
1717

1818
def test_layer_field_default_value_show():
1919
show = "test"
2020
test_layer_field = LayerField(show=show)
2121
default_value = test_layer_field.get_default_value()
22-
assert(default_value == show)
22+
assert default_value == show
2323

2424
def test_layer_field_default_value_value():
2525
value = "test"
2626
test_layer_field = LayerField(value=value)
2727
default_value = test_layer_field.get_default_value()
28-
assert(default_value == value)
28+
assert default_value == value
2929

3030
def test_layer_field_default_value_showname():
3131
showname = "test"
3232
test_layer_field = LayerField(showname=showname)
3333
default_value = test_layer_field.get_default_value()
34-
assert(default_value == showname)
34+
assert default_value == showname
3535

3636
def test_layer_field_showname_value():
3737
value = "test_value"
3838
showname = f"test: {value}"
3939
test_layer_field = LayerField(showname=showname)
40-
assert(value == test_layer_field.showname_value)
40+
assert value == test_layer_field.showname_value
4141

4242
def test_layer_field_showname_key():
4343
key = "test_key"
4444
showname = f"{key}: value"
4545
test_layer_field = LayerField(showname=showname)
46-
assert(key == test_layer_field.showname_key)
46+
assert key == test_layer_field.showname_key
4747

4848
def test_layer_field_showname_binary():
4949
binary = b"\x124"
5050
test_layer_field = LayerField(value="1234")
51-
assert(binary == test_layer_field.binary_value)
51+
assert binary == test_layer_field.binary_value
5252

5353
def test_layer_field_str_int_value():
5454
str_int_value = "10"
5555
int_value = 10
5656
test_layer_field = LayerField(value=str_int_value)
57-
assert(test_layer_field.int_value == int_value)
57+
assert test_layer_field.int_value == int_value
5858

5959
def test_layer_field_hex_value():
6060
test_int_value = "0x75BCD15"
6161
expected_value = 123456789
6262
test_layer_field = LayerField(value=test_int_value)
63-
assert(test_layer_field.hex_value == expected_value)
64-
# ---------------------------------------------------------------------------
63+
asserttest_layer_field.hex_value == expected_value
6564

6665
# Test Data - Layer Fields Container
67-
# **************************************************************************
6866
test_layer_field = LayerField(name="test_field", value={"test": "value"})
6967

7068
@pytest.fixture
7169
def layer_fields_container():
7270
return LayerFieldsContainer(test_layer_field)
73-
# ---------------------------------------------------------------------------
7471

7572
# Unit Tests - Layer Fields Container
76-
# **************************************************************************
7773
def test_layer_fields_container_adds_single_field(layer_fields_container):
7874
new_field = LayerField(name="new_field", value={"new_test": "new_test_value"})
7975
layer_fields_container.add_field(new_field)
8076
fields = layer_fields_container.all_fields
81-
assert(fields == [test_layer_field, new_field])
77+
assert fields == [test_layer_field, new_field]
8278

8379
def test_layer_fields_container_returns_all_fields(layer_fields_container):
8480
fields = layer_fields_container.all_fields
85-
assert(fields == [test_layer_field])
81+
assert fields == [test_layer_field]
8682

8783
def test_layer_fields_container_gets_main_field(layer_fields_container):
8884
main_field = layer_fields_container.main_field
89-
assert(main_field == test_layer_field)
85+
assert main_field == test_layer_field
9086

9187
def test_layer_fields_container_gets_alternate_fields(layer_fields_container):
9288
alternate_field_1 = LayerField(name="alt_field_1", value={"alt_field_1": "alt_value_1"})
9389
alternate_field_2 = LayerField(name="alt_field_2", value={"alt_field_2": "alt_value_2"})
9490
layer_fields_container.add_field(alternate_field_1)
9591
layer_fields_container.add_field(alternate_field_2)
9692
alternate_fields = layer_fields_container.alternate_fields
97-
assert(alternate_fields == [alternate_field_1, alternate_field_2])
98-
# ---------------------------------------------------------------------------
93+
assert alternate_fields == [alternate_field_1, alternate_field_2]

0 commit comments

Comments
 (0)