Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Factor" and "Texture" should not have separate headings #2459

Open
emackey opened this issue Nov 21, 2024 · 0 comments
Open

"Factor" and "Texture" should not have separate headings #2459

emackey opened this issue Nov 21, 2024 · 0 comments
Labels
PBR Physically Based Rendering specification

Comments

@emackey
Copy link
Member

emackey commented Nov 21, 2024

Pointed out by @lexaknyazev in #1825 (comment)

The KHR_materials_transmission and KHR_materials_diffuse_transmission extensions both have section headings that separate "Factor" from "Texture". This distinction is purely mechanical in glTF, it's a choice between uniform and per-texel settings, and does not affect how a given PBR parameter is used in the material. For example:

https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_transmission#transmissionfactor
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_transmission#transmissiontexture

https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_diffuse_transmission#diffusetransmissionfactor
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_diffuse_transmission#diffusetransmissioncolorfactor
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_diffuse_transmission#diffusetransmissiontexture
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Khronos/KHR_materials_diffuse_transmission#diffusetransmissioncolortexture

Ideally we should not use "Factor" or "Texture" in a section heading. The section heading should be just the name of the PBR parameter itself, such as "Transmission", "Diffuse Transmission", and "Diffuse Transmission Color".

@emackey emackey added specification PBR Physically Based Rendering labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PBR Physically Based Rendering specification
Projects
None yet
Development

No branches or pull requests

1 participant