Skip to content

Commit

Permalink
scripts: Fix user self-hosting dependency in update_deps.py
Browse files Browse the repository at this point in the history
The documentation states that users can override where to take a
dependency from via variables like VULKAN_HEADERS_INSTALL_DIR, however
the helper.cmake written by the scripts/CMakeLists.txt FORCE updates
the cache variable to the location inside known_good.json, practically
overwriting the user-provided path given on the CLI using -D, also
going into the cache.
  • Loading branch information
MathiasMagnus authored and charles-lunarg committed Oct 28, 2024
1 parent 7a96303 commit e94085e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/update_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ def CreateHelper(args, repos, filename):
if repo.api is not None and repo.api != args.api:
continue
if install_names and repo.name in install_names and repo.on_build_platform:
helper_file.write('set({var} "{dir}" CACHE STRING "" FORCE)\n'
helper_file.write('set({var} "{dir}" CACHE STRING "")\n'
.format(
var=install_names[repo.name],
dir=escape(repo.install_dir)))
Expand Down

0 comments on commit e94085e

Please sign in to comment.