Enable std::byte as vec's element type
#1058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec changes are at KhronosGroup/SYCL-Docs#674.
aelovikov-intel
force-pushed
the
vec-byte
branch
from
80e6378 to
1c2cec1
Compare
bader
reviewed
Feb 26, 2025
Comment on lines
1436
to
1438
| type_str, test_str, str(size)) | ||
| func_calls += make_func_call(TEST_NAME + '_ALL_TYPES', type_str, | ||
| str(size)) | ||
| str(size)) |
There was a problem hiding this comment.
It looks to me that the only change here is breaking the formatting. Can we revert this part?
There was a problem hiding this comment.
Thanks, that was a leftover of some intermediate steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec changes are at KhronosGroup/SYCL-Docs#674.