From 3560359affe082d4edabdaafa0bb4df581809f04 Mon Sep 17 00:00:00 2001 From: Brian DiRito Date: Fri, 26 Apr 2024 11:31:55 -0400 Subject: [PATCH] update-os-output-mac (#119) Updates `mac-setup.sh` script print statement to output `This is tested on macOS 14 (Sonoma).` now that this script has executed successfully 3 times on computers running macOS 14 and using M3 chips (3 new engineers, including myself, who are onboarding for the TX team). The script was able to run locally after the `echo` was updated. Author: Bcdirito Reviewers: Bcdirito, csilvers, MiguelCastillo Required Reviewers: Approved By: csilvers, MiguelCastillo Checks: Pull Request URL: https://github.com/Khan/khan-dotfiles/pull/119 --- mac-setup.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mac-setup.sh b/mac-setup.sh index 993b4cd..7449b86 100755 --- a/mac-setup.sh +++ b/mac-setup.sh @@ -50,11 +50,11 @@ DEVTOOLS_DIR="$REPOS_DIR/devtools" echo echo "Running Khan Installation Script 1.2" -if ! sw_vers -productVersion 2>/dev/null | grep -q '10\.1[12345]\.' ; then - echo "This is tested on macOS 13 (Ventura)." +if ! sw_vers -productVersion 2>/dev/null | grep -q '^1[0-4]\.' ; then + echo "This is tested on macOS 14 (Sonoma)." echo echo "If you find that this works on a newer version of macOS, " - echo "please update this message." + echo "please update this message and the grep of this if statement." echo fi