Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Aphrodite still actively maintained #393

Open
manian-kumaran opened this issue May 20, 2020 · 6 comments
Open

Is Aphrodite still actively maintained #393

manian-kumaran opened this issue May 20, 2020 · 6 comments

Comments

@manian-kumaran
Copy link

Hi,

The last release was v2.4.0 in Aug 2019, and there is 0 commits since then. The commits were far in between, only 27 commits since v. 2.2.3 in Aug 2018.

I see that the main contributors are no longer with Khan. Is Aphrodite still maintained?

Thanks.

@epicfaace
Copy link

@jeresig ?

@drianoaz
Copy link

👀

@Brianzchen
Copy link
Contributor

I too would also like to know. I've been using for lib forever and it's always been pretty stable, maybe it's a complete library.

I'd like to help maintain this project as I'm a huge fan if you need the help?

cc @lencioni

@jlfwong
Copy link
Collaborator

jlfwong commented Nov 28, 2020

FWIW, I don't personally do any active development on Aphrodite any more, but I also use it in https://github.com/jlfwong/speedscope, which is actively developed.

Can't speak for other owners/contributors, but I'm unlikely to add any significant contributions to Aphrodite going forward, but it's also not obvious that any significant changes are necessary for it to serve its purpose.

@Brianzchen
Copy link
Contributor

@jlfwong Thanks so much for replying, didn't think I'd get a reply from a collaborator 😄

I get that super active maintenance of this lib probably isn't necessary. But my interest is really triggered by a few main reasons

  • 2.4.0 #382 This PR hasn't been merged despite having been approved and actually released last year
  • And when I was exploring my node_modules/aphrodite as a flow user, the fact that this lib ships the flow config causes my flow sever to crash. Some healthy maintenance in what's published would be nice.
  • I've recently added flow definitions to flow-typed. It would be nice to add them directly to this project given it's written with flow, but seems like there's no maintainers Update and expose flow? #391

@jlfwong
Copy link
Collaborator

jlfwong commented Dec 6, 2020

I just merged #382 since it looks like it's authored by a core contributor and was approved by a KA employee.

I'm happy to merge updates to flow typings as long as you're willing to own any issues that arise in response to the merge @Brianzchen. I haven't published this repo in a very long time, however, so I might prefer to leave that to someone else, and I'm not totally sure who the right person to do that is any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants