Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom toolbar custom actions introduce padding (that probably should not be there) #94

Open
1 task done
dvmoritzschoefl opened this issue Jul 20, 2023 · 0 comments
Open
1 task done
Labels
V1 Issue with MRT V1

Comments

@dvmoritzschoefl
Copy link

mantine-react-table version

1.0.0

react & react-dom versions

18

Describe the bug and the steps to reproduce it

  1. Override 'renderBottomToolbarCustomActions'
  2. Add any custom action (for example a button)
  3. The container for both the action and the pagination now has a padding, which is correct I think
  4. However the pagination still has its old padding and therefore the total row height is now larger than before

Temporary I could fix this with

mantineBottomToolbarProps: { sx: { '> div': { paddingTop: 0, paddingBottom: 0, }, }, },

The screenshot shows the behavior. The total space above the pagination is larger with a custom action than without one

Minimal, Reproducible Example - (Optional, but Recommended)

enablePagination: true,
enableBottomToolbar: true,
renderBottomToolbarCustomActions: () => {
    return <div>content</div>
}

Screenshots or Videos (Optional)

image

Do you intend to try to help solve this bug with your own PR?

No, because I do not know how

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@alessandrojcm alessandrojcm added the V1 Issue with MRT V1 label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 Issue with MRT V1
Projects
None yet
Development

No branches or pull requests

2 participants