Skip to content

Commit 1dde49f

Browse files
chore: update benchmarks proposed by Roman Sharkov
Co-authored-by: Roman Sharkov <[email protected]>
1 parent 0c34307 commit 1dde49f

File tree

1 file changed

+10
-30
lines changed

1 file changed

+10
-30
lines changed

bench_test.go

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ import (
99
// setupBenchmarkSets creates BitSets of various sizes for benchmarking
1010
func setupBenchmarkSets() (BitSet, BitSet) {
1111
small := New()
12-
for i := 0; i < 100; i++ {
12+
for i := range 100 {
1313
if i%2 == 0 {
1414
small.Add(i)
1515
}
1616
}
1717

1818
large := New()
19-
for i := 0; i < 10000; i++ {
19+
for i := range 10000 {
2020
if i%2 == 0 {
2121
large.Add(i)
2222
}
@@ -40,22 +40,6 @@ func BenchmarkNew(b *testing.B) {
4040
}
4141
}
4242

43-
func BenchmarkBitSet_Reset(b *testing.B) {
44-
small, large := setupBenchmarkSets()
45-
46-
b.Run("small set", func(b *testing.B) {
47-
for b.Loop() {
48-
small.Reset()
49-
}
50-
})
51-
52-
b.Run("large set", func(b *testing.B) {
53-
for b.Loop() {
54-
large.Reset()
55-
}
56-
})
57-
}
58-
5943
func BenchmarkBitSet_Add(b *testing.B) {
6044
scenarios := []struct {
6145
name string
@@ -151,7 +135,7 @@ func BenchmarkBitSet_DeleteRange(b *testing.B) {
151135
func BenchmarkAnd(b *testing.B) {
152136
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
153137
large1, large2 := New(), New()
154-
for i := 0; i < 10000; i++ {
138+
for i := range 10000 {
155139
if i%2 == 0 {
156140
large1.Add(i)
157141
}
@@ -176,7 +160,7 @@ func BenchmarkAnd(b *testing.B) {
176160
func BenchmarkBitSet_And(b *testing.B) {
177161
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
178162
large1, large2 := New(), New()
179-
for i := 0; i < 10000; i++ {
163+
for i := range 10000 {
180164
if i%2 == 0 {
181165
large1.Add(i)
182166
}
@@ -201,7 +185,7 @@ func BenchmarkBitSet_And(b *testing.B) {
201185
func BenchmarkOr(b *testing.B) {
202186
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
203187
large1, large2 := New(), New()
204-
for i := 0; i < 10000; i++ {
188+
for i := range 10000 {
205189
if i%2 == 0 {
206190
large1.Add(i)
207191
}
@@ -226,7 +210,7 @@ func BenchmarkOr(b *testing.B) {
226210
func BenchmarkBitSet_Or(b *testing.B) {
227211
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
228212
large1, large2 := New(), New()
229-
for i := 0; i < 10000; i++ {
213+
for i := range 10000 {
230214
if i%2 == 0 {
231215
large1.Add(i)
232216
}
@@ -251,7 +235,7 @@ func BenchmarkBitSet_Or(b *testing.B) {
251235
func BenchmarkXor(b *testing.B) {
252236
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
253237
large1, large2 := New(), New()
254-
for i := 0; i < 10000; i++ {
238+
for i := range 10000 {
255239
if i%2 == 0 {
256240
large1.Add(i)
257241
}
@@ -276,7 +260,7 @@ func BenchmarkXor(b *testing.B) {
276260
func BenchmarkBitSet_Xor(b *testing.B) {
277261
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
278262
large1, large2 := New(), New()
279-
for i := 0; i < 10000; i++ {
263+
for i := range 10000 {
280264
if i%2 == 0 {
281265
large1.Add(i)
282266
}
@@ -298,12 +282,10 @@ func BenchmarkBitSet_Xor(b *testing.B) {
298282
})
299283
}
300284

301-
// --- NEW: Benchmarks for AND NOT ---
302-
303285
func BenchmarkAndNot(b *testing.B) {
304286
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
305287
large1, large2 := New(), New()
306-
for i := 0; i < 10000; i++ {
288+
for i := range 10000 {
307289
if i%2 == 0 {
308290
large1.Add(i)
309291
}
@@ -335,7 +317,7 @@ func BenchmarkAndNot(b *testing.B) {
335317
func BenchmarkBitSet_AndNot(b *testing.B) {
336318
small1, small2 := New(1, 2, 3, 4, 5), New(3, 4, 5, 6, 7)
337319
large1, large2 := New(), New()
338-
for i := 0; i < 10000; i++ {
320+
for i := range 10000 {
339321
if i%2 == 0 {
340322
large1.Add(i)
341323
}
@@ -364,8 +346,6 @@ func BenchmarkBitSet_AndNot(b *testing.B) {
364346
}
365347
}
366348

367-
// -----------------------------------
368-
369349
func BenchmarkBitSet_Copy(b *testing.B) {
370350
small, large := setupBenchmarkSets()
371351

0 commit comments

Comments
 (0)