Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcases we wish to support #6

Open
RangerMauve opened this issue Jan 9, 2023 · 6 comments
Open

Testcases we wish to support #6

RangerMauve opened this issue Jan 9, 2023 · 6 comments

Comments

@RangerMauve
Copy link
Contributor

This is an issue for tracking the sorts of tests we want to do (accross implementations) and test fixgures to load and generate.

This will also involve @SionoiS giving his insights from his work on fixutres for HAMT and his work on the Rust implementation

@SionoiS
Copy link

SionoiS commented Jan 9, 2023

Hi,

Would be cool to have all the data online. I got an IPFS node at home if needed.

Since trees need rebalancing designing some tests so that they result in the absolute worst case possible is a good start.

MSTs worst case for a single change is one merge/split per layer for example.

@SionoiS
Copy link

SionoiS commented Jan 16, 2023

Just added my first test for MSTs. Are batch write idempotent? Should be true.

@sssion
Copy link
Member

sssion commented Jan 16, 2023

@SionoiS
Copy link

SionoiS commented Jan 16, 2023

@sssion The goal would be to have language agnostic test fixtures.

First step would be to make a list of the tests we want.

@sssion
Copy link
Member

sssion commented Jan 17, 2023

@SionoiS I replace the data file with car file, now the data is a map(ipld) node, the k/v pair in the map node is the raw data, (key should be converted from bytes to string). But the map node iter not keep the input pairs order, we should sort it before using

@SionoiS
Copy link

SionoiS commented Jan 18, 2023

Just add my first test for MSTs. Are batch write idempotent? Should be true.

@sssion I made a mistake in my post. It sounded like I wanted someone to add the test in this repo. That's not the case. Sorry.

I want us to brainstorm all the test cases we can think of then keep the best ones.

Description of the tests and CIDs for initial/end states is the data we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants