Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private registry support on Megalos #283

Open
GioBar00 opened this issue Mar 28, 2024 · 1 comment
Open

Private registry support on Megalos #283

GioBar00 opened this issue Mar 28, 2024 · 1 comment
Assignees

Comments

@GioBar00
Copy link

GioBar00 commented Mar 28, 2024

Feature Description

It would allow the use of images contained in private registries that one might not want to be available to the public.

To add private registry access in Kubernetes, it is required that a kubernetes.io/dockerconfigjson secret is created.
Furthermore an imagePullSecrets specification needs to be added to the pods or to a service account.

The problem is that Kubernetes secrets are namespaced so the Kubernetes secret needs to be added after the namespace is created, but before the pods are deployed. This becomes unfeasible when starting a Kathará lab.

Solution

I have created a pull request #282 with a possible solution.

@tcaiazzi
Copy link
Member

Hi @GioBar00,

Thanks for the PR and the help! We really appreciate it!

We will review the changes to merge them as soon as possible.

Ciao,
Tommaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Review
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants