Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Pre-commit hook for automatic Prettier formatting #245

Open
unimu-cic opened this issue Nov 21, 2023 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@unimu-cic
Copy link
Contributor

Problem

Currently, the codebase doesn't seem to have an automated way to format code with Prettier before commits, which can result in formatting inconsistencies and extra manual work.

Suggested Solution

It might be beneficial for the project to use a pre-commit hook mechanism like Husky and lint-staged to automatically format staged files with Prettier upon commit. This would ensure code formatting stays consistent and reduces the manual effort required for code formatting.

Benefits

  • Consistent code formatting across all contributions
  • Less manual intervention and potential human error
  • Streamlined code review process focusing on the code quality rather than formatting

Implementation

If this feature request is accepted, I would be happy to work on it or assist in any way possible. I can contribute a PR including the Husky setup and the necessary lint-staged configuration.

Thank you for considering this suggestion, and I look forward to hearing your thoughts.

@ObservedObserver ObservedObserver added the good first issue Good for newcomers label Nov 23, 2023
@ObservedObserver
Copy link
Member

ObservedObserver commented Nov 23, 2023

Thanks for the advice, it would be very welcome if you are interested in making a PR on this.

@BassCoder2808
Copy link
Contributor

Hi @ObservedObserver, I would like to work on this issue if it is still open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants