Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any motivation to make this into an npm package? #21

Open
dkaushik95 opened this issue Feb 26, 2019 · 3 comments
Open

Any motivation to make this into an npm package? #21

dkaushik95 opened this issue Feb 26, 2019 · 3 comments

Comments

@dkaushik95
Copy link

Hey,

Is there any motivation to make this into an npm package? I am trying to make an application where I will be using dictate.js with react. Are you motivated to make this into an npm package? I don't have any experience in building an npm package but I can help remove jquery and add npm-based javascript.

Thanks,

@Kaljurand
Copy link
Owner

This might be a good idea, but I don't have any experience with npm either. Feel free to do this in a fork. As far as I can see there is no jQuery in dictate.js.

@dkaushik95
Copy link
Author

There is a $ajax here. I have made some changes to make it into a react component. I'll put a PR soon.

@Kaljurand
Copy link
Owner

Right, I wasn't even aware of that "$.ajax" call. I'd say the "submitReference" is not such an essential feature of "dictate.js", i.e. you might not need it for your use case. Maybe we could also remove it from "dictate.js" to have less dependencies. Adding @alumae for possible comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants