-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression introduced by 5c4833e. Closes: #140 #141
base: main
Are you sure you want to change the base?
Conversation
- add platformdirs python library to runtime dependencies - use platformdirs' magic to determine where to store user data
I express my appreciation for your feedback on the recent code changes. I understand your concerns regarding the regressions introduced by the recent commits. I'd like to clarify that my intention was to propose an additional function to address an issue I encountered. I certainly didn't intend to introduce poor code or regressions intentionally, and if my changes have caused any issues, I genuinely apologize for any inconvenience they may have caused. While I'm responsible for my contributions, the code manager or maintainer typically plays a significant role in reviewing, approving, and merging changes into the codebase. Additionally, I kindly request that we maintain a respectful and constructive tone in our interactions. Harassment or hostile behaviour seen can be detrimental to the collaborative spirit of any project. Please understand that I may not be able to respond promptly to further messages (busy). I appreciate your understanding and patience. Thanks lots. :) |
@olichuuwon, your constant demands for a constructive and respectful tone would find more sympathy if you showed more respect and cleaned up after yourself instead of relying on others to fix the problems you created. Or at least if you showed a willingness to learn and improve your skills so that the same mistakes won't repeat. You've been given a number of concrete examples. As of now you simply come across as someone utterly unconcerned with quality of code and other collaborators' work, hiding behind the fact that the maintainer did not catch the mess you pushed. May I suggest you take some responsibility for and pride in the contributions you make? |
Your dedication is truly something to admire. I'll certainly take your wisdom to heart and strive to be as perfect as you are. It's a privilege to be schooled by someone of your stature. I'll strive to write code quality at the awe-inspiring level you've set, though with standards set so high, I acknowledge that it might take some time to reach them. |
5c4833e reflects poorly on the author of that code change and it also reflects poorly on the maintainer for allowing this to be merged obviously without even looking at the code change. Please do better next time, people trust to run your code, be worthy of that trust.
reverting the following regressions by cherry-picking previous commits to close #140
#104
#105
#108
reintroduce 3611a0c