Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we still need to deal with ModuleAnimateHeat? #20

Open
blowfishpro opened this issue Sep 16, 2016 · 2 comments
Open

Do we still need to deal with ModuleAnimateHeat? #20

blowfishpro opened this issue Sep 16, 2016 · 2 comments

Comments

@blowfishpro
Copy link
Member

https://github.com/KSP-RO/SolverEngines/blob/master/SolverEngines/EngineModule.cs#L61

It looks like ModuleEnginesSolver has a lot of special handling for ModuleAnimateHeat, however since KSP 1.0.5 most engines have moved away from that anyway. Do we still need this code?
@NathanKell
Copy link
Member

Yes, we do. The point is to control the emissive animations. Stock swapped to FXModuleAnimateThrottle to handle emissives more like we already do. :)

We probably should make it generic however (via IScalarModule) rather than driving ModuleAnimateHeat in particular.

@blowfishpro
Copy link
Member Author

blowfishpro commented Sep 23, 2016 •
edited
Loading

Hmm, I'm having trouble finding any engines still using ModuleAnimateHeat except for a couple in RO. Switching to changing any IScalarModule could potentially have some unwanted side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NathanKell @blowfishpro