Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneously possible to roll out a rocket to a launchpad whilst it is reconditioning #2344

Open
njits23 opened this issue Mar 31, 2024 · 1 comment

Comments

@njits23
Copy link
Contributor

njits23 commented Mar 31, 2024

It is not supposed to be possible to roll out a craft to a pad that's currently reconditioning.
However, if you open the Space Center Management window whilst you are in the flight scene, but your current craft is still attached to its launch clamps, you can roll out another rocket to the same pad.
Once you take off, that rollout will continue alongside the pad reconditioning. You cannot roll a rocket to the same pad after you have taken off, but are still in the flight scene.

If the rollout finishes before the pad reconditioning, it is possible to launch the rocket before the pad reconditioning has finished.
Launching that rocket will start a second reconditioning timer on the same launchpad.

@njits23 njits23 changed the title Erroneously possible to simultaneously roll out a rocket to a launchpad whilst it reconditions Erroneously possible to roll out a rocket to a launchpad whilst it reconditions Mar 31, 2024
@njits23 njits23 changed the title Erroneously possible to roll out a rocket to a launchpad whilst it reconditions Erroneously possible to roll out a rocket to a launchpad just before it will start reconditioning Mar 31, 2024
@njits23 njits23 changed the title Erroneously possible to roll out a rocket to a launchpad just before it will start reconditioning Erroneously possible to roll out a rocket to a launchpad just whilst it is reconditioning Mar 31, 2024
@njits23 njits23 changed the title Erroneously possible to roll out a rocket to a launchpad just whilst it is reconditioning Erroneously possible to roll out a rocket to a launchpad whilst it is reconditioning Mar 31, 2024
@siimav
Copy link
Contributor

siimav commented May 11, 2024

OOOF, this is hard to fix. LC doesn't know anything about a vessel being launched from it. Instead when something leaves Prelaunch state, the code looks if there's a LC + pad associated with it and then adds reconditioning. I would imagine this issue can also happen in other scenes or when another vessel is active. Searching through all living vessels if they're associated to a LC + pad and haven't actually launched sounds like a really bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants